Skip to content

DC-456 - spinner-only loading state for DC id-proofing; stop copy key leak#364

Merged
necampanini merged 4 commits into
mainfrom
fix/DC-456-dc-loading-interstitial
Jun 1, 2026
Merged

DC-456 - spinner-only loading state for DC id-proofing; stop copy key leak#364
necampanini merged 4 commits into
mainfrom
fix/DC-456-dc-loading-interstitial

Conversation

@necampanini
Copy link
Copy Markdown
Contributor

@necampanini necampanini commented May 28, 2026

🔗 Jira ticket

DC-456

✍️ Description

DC users who submitted the id-proofing form briefly saw the literal text "title" and "body" inside a blue box while the request was in flight. The form used LoadingInterstitial with i18n keys from the step-upProcessing namespace, which is only populated for CO (DC's content sheet marks those rows !N/A!), so i18next fell back to the key names. The loading branch now gates on copy presence in the active locale bundle (i18n.exists('step-upProcessing:title') && i18n.exists('step-upProcessing:body')): when the keys exist the titled LoadingInterstitial renders, when they don't the form falls back to a centered USWDS spinner inside a role="status" region. Adding the copy upstream is enough to switch in the titled interstitial for any state, no code change needed.

🔗 Links to related PRs

  • {sibling repo / branch — leave a placeholder if not yet pushed}

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria in ticket
  • Configuration changes:
    • If new environment variables are added, update in Tofu
    • If new environment secrets are added, update in Tofu and set in AWS Secret Manager
    • If you're adding an appsetting, add it to the requisite example file, and update it in the AWS AppConfig
    • If appsetttings are changed, update in AWS AppConfig

Priority Review Table

Priority File Unit Sec Cpx Nov Notes
🟡 IdProofingForm.tsx loading-state branch Low Low Med new presence-check gate, a11y on spinner
🟢 IdProofingForm.test.tsx two new tests covering both gate branches Low Low Low i18n bundle add/remove via try/finally

@noxmwalsh noxmwalsh self-requested a review May 29, 2026 20:55
@necampanini necampanini merged commit 9a3f83b into main Jun 1, 2026
24 checks passed
@necampanini necampanini deleted the fix/DC-456-dc-loading-interstitial branch June 1, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants